-
Notifications
You must be signed in to change notification settings - Fork 6
Implement fistpoint for smapi in tests #340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Nambrok
wants to merge
6
commits into
master
Choose a base branch
from
dtt-fp
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ydirson
reviewed
Jul 11, 2025
And a `exit_on_fistpoint` fixture to enable the behavior of exiting instead of pausing 30 seconds at normal fistpoint Signed-off-by: Damien Thenot <[email protected]>
Signed-off-by: Damien Thenot <[email protected]>
Signed-off-by: Damien Thenot <[email protected]>
Signed-off-by: Damien Thenot <[email protected]>
d6691fc
to
578fffb
Compare
Signed-off-by: Damien Thenot <[email protected]>
Wescoeur
requested changes
Jul 24, 2025
Wescoeur
approved these changes
Jul 25, 2025
lib/vdi.py: Renamed `size` to `get_virtual_size` tests/storage/ext/test_ext_sr.py: Changed to use `vdi.get_virtual_size()` Fix Exception type in `test_failing_resize` tests/storage/lvm/test_lvm_sr.py: Changed to use `vdi.get_virtual_size()` Changed Exception handling to use `pytest.raises()` Signed-off-by: Damien Thenot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implement the usage of fistpoint for testing some errors in smapi.
A fistpoint is an action that you can enable in the smapi to for example add a sleep at some point or raise an exception.
For example:
Activating the fistpoint
blktap_activate_inject_failure
mean that the VDI activation will fail.This fistpoint always raise an exception but most fistpoint just add a sleep in the code.
Using the fixture
exit_on_fistpoint
make all fistpoint raise an exception instead by enabling a special fistpoint calledfist_LVHDRT_exit
.